[222_51]: fix: override tooltip to Toggle cell alignment in tabular context only.#2938
[222_51]: fix: override tooltip to Toggle cell alignment in tabular context only.#2938Prashant27-07 wants to merge 4 commits intoMoganLab:mainfrom
Conversation
|
Fixes #2852 |
|
Also, documentation and PR number are required. |
7c22ae7 to
4abd0e7
Compare
4abd0e7 to
53d3326
Compare
|
Hi @JackYansongLi I have updated the fix. The tooltip change is now only applied in tabular context using table-markup-context? in table-menu.scm. The generic-menu.scm and text-menu.scm are reverted back to 'Toggle numbering'. Please review. |
|
@Prashant27-07 Please refer to the guidelines in https://github.com/MoganLab/mogan/blob/main/CONTRIBUTING.md, thanks. |
53d3326 to
eec4fa9
Compare
|
Updated the commit to [222_51] and added the developer documentation file devel/222_51.md as required by CONTRIBUTING.md. The fix now correctly overrides the tooltip only in tabular context using table-markup-context?. |
|
please also change the title of this PR. |
|
@JackYansongLi Done. |
|
@Prashant27-07 Hello, your devel file has a problem; it is conflicting with someone else's. |
|
Then I think that just modifying the text explanation is not very meaningful; the icon should be replaced accordingly. The aligned icon already exists in mogan\TeXmacs\misc\pixmaps\liii\16x16\focus. |
|
@Yuki-Nagori Hi I found the line using tm_numbered.xpm in table-menu.scm. Could you tell me the exact icon filename from liii/16x16/focus that should replace it for the cell alignment button? |
|
@Prashant27-07 I think like tabular and tabular* should be used separately, rather than sharing a function with the numbering switch like before. Then tm_cell_left and tm_cell_center can have a toggle set up. What do you think? |
|
Hi @Yuki-Nagori, when I resolved the conflict in devel/222_51.md, I accepted both changes which merged my content with another person's content into the same file. Should I remove the other person's content and keep only my tooltip fix documentation |
|
Hi @Yuki-Nagori, that sounds like a good approach! Could you guide me a bit on how to implement the toggle setup with tm_cell_left and tm_cell_center? I want to make sure I implement it correctly. |
|
@Prashant27-07 Regarding this issue, I noticed that you used merge instead of rebase. I suggest you use rebase next time. |
@Prashant27-07 Search in the code repository for alternate-first-icon and alternate-second-icon, I think it should be similar to it.
|
b81cf3f to
26b2a9c
Compare
|
@Yuki-Nagori I've added the alternate icon overrides for tabular context using tm_cell_left.xpm and tm_cell_center.xpm, and cleaned up the devel file. Please review when you get a chance. |
|
@Prashant27-07 Your devel is still written incorrectly. Why not just create a new devel with a new number? Also, your code is clearly wrong. I just sent you a reference example. How can you just use it directly? Besides, you would know it's useless just by testing it. You need to improve your Git knowledge, PR closed. |
|
@Yuki-Nagori I apologize for the messy PR. I'm learning Git and made several mistakes. Could you please share the reference example you mentioned? I'd like to learn from it and do it correctly next time. |
|
@Prashant27-07 I've been quite busy recently, and I'm not very familiar with this part of the code. I think you can start with simpler PRs, and then improve your Git skills. Keep it up! |
|
@Yuki-Nagori Thank you for the encouragement! I've already started working on simpler PRs and improving my Git skills. I'll keep it up. |


the tooltip "Toggle numbering" was misleading - the button actually toggles cell alignment (tabular vs tabular*), not numbering. Changed the tooltip to "Toggle cell alignment" in generic-menu.scm and text-menu.scm.